-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Patient Identifiers #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
approved these changes
Feb 18, 2022
# check if there are patients that use one of the removed keys | ||
brains = patient_search({"patient_identifier_keys": removed}) | ||
if brains: | ||
raise Invalid(_("Can not delete identifiers that are in use")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, this is called "attention to detail" ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR adds configurable identifiers for patients.
Identifiers can be e.g. Drivers License, Voter ID, Passport ID etc.
and can be configured in the Patient setup:
Multiple identifiers can then be added to a patient:
Note: Identifiers that are in use can not be deleted! Only the title can be changed afterwards.
Current behavior before PR
No identifiers for patients available
Desired behavior after PR is merged
Identifiers can be configured for patients
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.