Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoping Functions and Adding Multiple GL Context Support #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

D1plo1d
Copy link

@D1plo1d D1plo1d commented Feb 6, 2013

GL Contexts: Previously PhiloGL was only able to support a single GL context at a time. Thanks to some refactoring that is no longer the case. Commit 818b319 adds multiple context support so now we can create as many webGL canvases as we want with PhiloGL.

Scoping: The $ was previously polluting the global name space when I included the individual src files of PhiloGL directly so I scoped it to PhiloGL.$ and aliased $ to it inside each closure. Also the app and globalContext variables were removed from the top level global namespace. PhiloGL should now be the only addition to the top level global namespace.

branch.gl = gl;
branch.Utils = PhiloGL.$;
};
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this wrapper function never gets called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants