-
Notifications
You must be signed in to change notification settings - Fork 54
Pull Request for Issue #86 - Fix dependency vulnerabilities #87
Conversation
Additional vulnerabilities was flagged out by running |
This is awesome @robincher! I've added this to our backlog for a review and merge. With Best Regards, Elmer |
package.json
Outdated
@@ -5,7 +5,7 @@ | |||
], | |||
"name": "sendgrid-rest", | |||
"description": "HTTP REST client, simplified for Node.js.", | |||
"version": "2.4.0", | |||
"version": "2.4.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this back to 2.4.0. I will be updating the version number at the next release. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, will commit the corresponding package-lock.json too
…o fix vulnerabilities
Hi @thinkingserious , additionally i updated the dev dependency - mocha to the latest. The previous version 2.x.x was having vulnerabilities if you run Update |
Note to code reviewers: we need to make sure none of these updates are breaking changes. |
Hello @robincher, |
…o fix vulnerabilities
Opps sorry @thinkingserious , i have a separate PR (incoming), so i have reverted the wrong commits. Need you to resign the CLA again :( |
Mege upstream commits for mocha
Closing in favor of #117 |
Fixes #86
Checklist
Short description of what this PR does: