Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "file_lines" issue in packages/helpers/classes/mail.js #553

Closed
thinkingserious opened this issue Oct 27, 2017 · 0 comments · Fixed by #602
Closed

Fix "file_lines" issue in packages/helpers/classes/mail.js #553

thinkingserious opened this issue Oct 27, 2017 · 0 comments · Fixed by #602
Labels
difficulty: easy fix is easy in difficulty type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 27, 2017 •
edited by mbernier
Loading

File mail.js has 383 lines of code (exceeds 250 allowed). Consider refactoring.

Move each example out to its own file and add a markdown that links to each example.

https://codeclimate.com/github/sendgrid/sendgrid-nodejs/packages/helpers/classes/mail.js#issue_59f39f43b5ec1a000100006d
@martiuslim martiuslim mentioned this issue Oct 30, 2017
Closed
@jstevans jstevans mentioned this issue Nov 1, 2017
Merged
6 tasks
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Mar 5, 2018
@childish-sambino childish-sambino added type: community enhancement feature request not on Twilio's roadmap and removed status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Deduplicate typechecks in setters jstevans/sendgrid-nodejs
2 participants
@thinkingserious @childish-sambino