-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deduplicate typechecks in setters #602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
requesting a community code review or review from Twilio
label
Nov 1, 2017
We can’t merge your PR without the CLA being signed. [ ] Sign the CLA before November 3rd Then we will comment with a link to get your shirt! |
@mbernier @thinkingserious Thanks! |
thinkingserious
added
difficulty: easy
fix is easy in difficulty
type: twilio enhancement
feature request on Twilio's roadmap
labels
Mar 6, 2018
childish-sambino
force-pushed
the
master
branch
5 times, most recently
from
January 15, 2020 21:44
389fa8c
to
37473ad
Compare
childish-sambino
removed
the
type: twilio enhancement
feature request on Twilio's roadmap
label
Jul 20, 2020
eshanholtz
force-pushed
the
dedupeTypechecks
branch
from
September 25, 2020 22:58
053c5f9
to
2d7658e
Compare
childish-sambino
changed the title
Deduplicate typechecks in setters
chore: Deduplicate typechecks in setters
Oct 12, 2020
childish-sambino
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
difficulty: easy
fix is easy in difficulty
status: code review request
requesting a community code review or review from Twilio
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.