Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for dynamic_template_data #689

Closed
therajumandapati opened this issue May 30, 2018 · 3 comments · Fixed by #691
Closed

Support for dynamic_template_data #689

therajumandapati opened this issue May 30, 2018 · 3 comments · Fixed by #691
Labels
difficulty: unknown or n/a fix is unknown in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Comments

@therajumandapati
Copy link
Contributor

Issue Summary

When is the support coming for the usage of dynamic_template_data as per the documentation in https://github.com/sendgrid/email-templates/tree/master/dynamic-templates

Looks like the go library already supports it: https://github.com/sendgrid/smtpapi-go/blob/master/smtpapi.go#L27
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: work in progress Twilio or the community is in the process of implementing difficulty: unknown or n/a fix is unknown in difficulty labels May 30, 2018
@thinkingserious
Copy link
Contributor

Hello @mvpspl619,

A PR should be coming shortly, hopefully within this quarter.

With Best Regards,

Elmer

@therajumandapati
Copy link
Contributor Author

@thinkingserious I'm working on this now, PR may come hopefully today

@therajumandapati therajumandapati mentioned this issue May 30, 2018
Merged
6 tasks
@therajumandapati
Copy link
Contributor Author

@thinkingserious Added the PR here: #691

therajumandapati added a commit to prohabits/sendgrid-nodejs that referenced this issue May 30, 2018
@therajumandapati
Fixing broken build for sendgrid#689
2abbbce
@thinkingserious thinkingserious mentioned this issue Jul 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: unknown or n/a fix is unknown in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for dynamicTemplateData prohabits/sendgrid-nodejs
2 participants
@thinkingserious @therajumandapati