Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump axios version #1239

Merged
merged 3 commits into from
Jan 6, 2021
Merged

chore: bump axios version #1239

merged 3 commits into from
Jan 6, 2021

Conversation

fileformat
Copy link
Contributor

Fixes

  • Bumps axios version dependency and related sendgrid version numbers
  • Updated year in LICENSE to pass CI test

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 5, 2021
@fileformat
Copy link
Contributor Author

I also added maxBodyLength to try to get the tests to pass, but now Travis is running in docker pull rate limits.

@eshanholtz eshanholtz changed the title FIX: bump axios version AND license year fix: bump axios version and license year Jan 6, 2021
eshanholtz
eshanholtz suggested changes Jan 6, 2021
View reviewed changes
packages/mail/package.json Outdated Show resolved Hide resolved
@eshanholtz eshanholtz mentioned this pull request Jan 6, 2021
Closed
8 tasks
@fileformat fileformat requested a review from eshanholtz January 6, 2021 03:02
@matt-catellier matt-catellier mentioned this pull request Jan 6, 2021
Closed
@sjbeatle
Copy link

sjbeatle commented Jan 6, 2021

Is it possible to expedite this?

@eshanholtz
Copy link
Contributor

@sjbeatle Yes! We're releasing a new version with the security fix today.

@eshanholtz eshanholtz closed this in dac8f6a Jan 6, 2021
@eshanholtz eshanholtz reopened this Jan 6, 2021
@eshanholtz eshanholtz changed the title fix: bump axios version and license year chore: bump axios version and license year Jan 6, 2021
@eshanholtz eshanholtz changed the title chore: bump axios version and license year chore: bump axios version Jan 6, 2021
@eshanholtz eshanholtz merged commit 405cc3e into sendgrid:main Jan 6, 2021
@thinkingserious thinkingserious mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarcuse amarcuse amarcuse left review comments

@eshanholtz eshanholtz eshanholtz requested changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fileformat @sjbeatle @eshanholtz @amarcuse @thinkingserious