Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add signed webhook test for multi event payload #1271

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke commented Apr 29, 2021

Add example to show how to process payloads with multiple events for signed webhook verification.

Note: The webhook verification logic itself works fine with the raw request body in the example shown here.

Fixes #1238

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 29, 2021
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should link this to the open issue.

@shwetha-manvinkurke shwetha-manvinkurke merged commit 15176de into main Apr 29, 2021
@shwetha-manvinkurke shwetha-manvinkurke deleted the webhook-test-fix branch April 29, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Webhook only works for a single event payload
3 participants