Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating attachment types #1287

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Conversation

cryptiklemur
Copy link
Contributor

@cryptiklemur cryptiklemur commented Aug 4, 2021

Attachment's properties are inherently public, and need to be typed as such

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

cryptiklemur and others added 2 commits August 3, 2021 23:55
Attachment's properties are inherently public, and need to be typed as such
@eshanholtz eshanholtz changed the title Updating attachment types fix: updating attachment types Aug 5, 2021
@eshanholtz eshanholtz changed the title fix: updating attachment types fix: Updating attachment types Aug 5, 2021
@eshanholtz eshanholtz merged commit d8ba9e9 into sendgrid:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants