fix: Fix typings for eventwebhook.d.ts PublicKey #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Installing
@sendgrid/eventwebhook
in a project using typescript cannot properly compile becausestarkbank-ecdsa
does not provide any typings and none are available in DefinitelyTyped project either.Right now the only way to use the module is to ourselves provide a definition of
starkbank-ecdsa
OR patch-package@sendgrid/eventwebhook
I've decided to change the import statement with a minimal interface of
PublicKey
which should be enough to use the package properly in a typescript project.Technically speaking,
@types/node
is also required because you useBuffer
in the types, but a typescript project without it would be weird so I think we can let that one as-is.Checklist