-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix typings for eventwebhook.d.ts PublicKey #1351
Merged
childish-sambino
merged 2 commits into
sendgrid:main
from
Cellule:eventwebhook-publickey-typings
Mar 25, 2022
Merged
fix: Fix typings for eventwebhook.d.ts PublicKey #1351
childish-sambino
merged 2 commits into
sendgrid:main
from
Cellule:eventwebhook-publickey-typings
Mar 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
childish-sambino
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 4, 2024
This was referenced Sep 13, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Installing
@sendgrid/eventwebhook
in a project using typescript cannot properly compile becausestarkbank-ecdsa
does not provide any typings and none are available in DefinitelyTyped project either.Right now the only way to use the module is to ourselves provide a definition of
starkbank-ecdsa
OR patch-package@sendgrid/eventwebhook
I've decided to change the import statement with a minimal interface of
PublicKey
which should be enough to use the package properly in a typescript project.Technically speaking,
@types/node
is also required because you useBuffer
in the types, but a typescript project without it would be weird so I think we can let that one as-is.Checklist