Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add method chaining in mail-service.js #712

Merged
merged 2 commits into from
Oct 16, 2020
Merged

feat: Add method chaining in mail-service.js #712

merged 2 commits into from
Oct 16, 2020

Conversation

hjmsw
Copy link
Contributor

@hjmsw hjmsw commented Jul 31, 2018 •
edited
Loading

Fixes #682

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

Short description of what this PR does:

Adds method chaining to mail-service.js, as demonstrated in #682

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 31, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Jul 31, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @hjmsw!

This has been added to our backlog for a code review. We are a bit backlogged, so it may be some time, but we greatly appreciate your contribution!

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty labels Aug 4, 2018
Ditofry
Ditofry approved these changes Oct 30, 2018
View reviewed changes
Copy link

@Ditofry Ditofry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is glorious 🕺 🚢 🎊

@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino removed the type: community enhancement feature request not on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:34
@childish-sambino childish-sambino changed the title Add method chaining in mail-service.js feat: Add method chaining in mail-service.js Oct 16, 2020
childish-sambino
childish-sambino approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@childish-sambino childish-sambino merged commit 0cd41f7 into sendgrid:main Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

@Ditofry Ditofry Ditofry approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow method chaining in @sendgrid/mail
5 participants
@hjmsw @SendGridDX @thinkingserious @Ditofry @childish-sambino