Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to include the CLA #751

Merged
merged 3 commits into from
Oct 5, 2018
Merged

Update README.md to include the CLA #751

merged 3 commits into from
Oct 5, 2018

Conversation

bharatr21
Copy link
Contributor

Updated README to include the CLA (Contributor Licensing Agreement) for this repo

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds a CLA (Contributor License Agreement in README.md section

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@bharatr21
Update README.md to include the CLA
8585b2c 
Updated README to include the CLA (Contributor Licensing Agreement) for this repo
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 1, 2018
@bharatr21 bharatr21 mentioned this pull request Oct 1, 2018
Closed
thinkingserious
thinkingserious requested changes Oct 2, 2018
View reviewed changes
README.md Outdated
@@ -62,6 +62,7 @@ We encourage contribution to our libraries (you might even score some nifty swag

* [Feature Request](https://github.com/sendgrid/sendgrid-nodejs/tree/master/CONTRIBUTING.md#feature_request)
* [Bug Reports](https://github.com/sendgrid/sendgrid-nodejs/tree/master/CONTRIBUTING.md#submit_a_bug_report)
* [Sign the CLA to Create a Pull Request](https://cla.sendgrid.com/sendgrid/sendgrid-nodejs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this list in alphabetical order. So this would go under "Review Pull Requests". Thanks!

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 2, 2018
@thinkingserious thinkingserious added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 5, 2018
@thinkingserious
Copy link
Contributor

Hello @Bharat123rox,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 1562c15 into sendgrid:master Oct 5, 2018
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharatr21 @thinkingserious