Contributing.md broken links fix #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
reedsa
reviewed
Oct 10, 2018
CONTRIBUTING.md
Outdated
| @@ -81,7 +81,7 @@ npm install | |||
|
|
|||
| First, get your free SendGrid account [here](https://sendgrid.com/free?source=sendgrid-nodejs). | |||
|
|
|||
| You will need to setup the following environment to use the SendGrid examples in the [README.md](https://github.com/sendgrid/sendgrid-nodejs/blob/master/README.md), [USAGE.md](https://github.com/sendgrid/sendgrid-nodejs/blob/master/USAGE.MD) and [USE_CASES.md](https://github.com/sendgrid/sendgrid-nodejs/blob/master/USE_CASES.md) files: | |||
| You will need to setup the following environment to use the SendGrid examples in the [README.md](https://github.com/sendgrid/sendgrid-nodejs/blob/master/README.md), [USAGE.md](https://github.com/sendgrid/sendgrid-nodejs/blob/master/USAGE.md) and [USE_CASES](https://github.com/sendgrid/sendgrid-nodejs/blob/master/use-cases/README.md) files: | |||
There was a problem hiding this comment.
I think we should use relative links in our docs to have GH link to the proper file based on whatever branch someone might be viewing from. https://blog.github.com/2013-01-31-relative-links-in-markup-files/
Also not sure about removing .md from the link, or maybe instead remove .md from all for consistency.
reedsa
added
status: waiting for feedback
|
@reedsa thank you for the review, updated links to relative links. |
reedsa
approved these changes
Oct 11, 2018
reedsa
added
status: ready for deploy
6 tasks
devchas
added
the
status: work in progress
thinkingserious
added
hacktoberfest
difficulty: easy
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.