Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inbound parse webhook example #792

Merged
merged 9 commits into from
Oct 10, 2018

Conversation

aroach
Copy link
Contributor

@aroach aroach commented Oct 8, 2018

Fixes

#787

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This is a docker container that can receive Inbound Parse webhooks from SendGrid

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 8, 2018
@aroach aroach force-pushed the inbound-parse-docker branch from 17885b1 to 0cb87a6 Compare October 9, 2018 04:12
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I may have missed it, but left a comment in regards to another section in the AC for the issue covered here.

@@ -0,0 +1,21 @@
# Introduction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reference to the AC, we'll want some documentation around deployment to a cloud service and how to start processing events.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let me see what I can do there. I was just using ngrok to test.

@aroach
Copy link
Contributor Author

aroach commented Oct 9, 2018

@reedsa I don't have a cloud environment at the moment to document everything in a cloud deployment. I added Kubernetes manifests and documented how to deploy using Kubernetes running locally.

@thinkingserious thinkingserious added hacktoberfest difficulty: very hard fix is very hard in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 10, 2018
@thinkingserious
Copy link
Contributor

Hello @aroach,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@reedsa
Copy link
Contributor

reedsa commented Oct 10, 2018

@aroach Awesome work on the docs! Thanks for the extra effort on this one, I know there was a lot to take care of. 💯 👍

Not certain if another issue should be created to cover the deployment specific stuff at a later time?

@reedsa reedsa added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 10, 2018
@thinkingserious thinkingserious merged commit 7a9a2d3 into sendgrid:master Oct 10, 2018
@aroach
Copy link
Contributor Author

aroach commented Oct 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: very hard fix is very hard in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants