Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Prism version to 2.x/Latest. Fixes #755 #797

Closed

Conversation

YoungNastyMan
Copy link

@YoungNastyMan YoungNastyMan commented Oct 10, 2018

Fixes #755

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Switches 2 mkdir calls to one mkdir -p call (this is a minor refactor) in travis.yml
  • Changes the prism:install npm script to use Prism 2.x. This might need to be updated again if prism changes the location of their install.sh
  • Changes the prism npm script to work with Prism 2.x. The --list switch is no longer supported apparently
  • Changes test/prism.sh to use the latest version everytime. This was commented out earlier for some reason?

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 10, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 10, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@devchas devchas added hacktoberfest difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 11, 2018
@childish-sambino
Copy link
Contributor

Closing as this was fixed by #1112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update integration tests to utilize StopLight.io's Prism version v2.X
5 participants