Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event webhook docker #804

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Event webhook docker #804

merged 3 commits into from
Oct 29, 2018

Conversation

aroach
Copy link
Contributor

@aroach aroach commented Oct 13, 2018 •
edited
Loading

Fixes

Fixes #786

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Updates the previous inbound-parse container to also support event webhooks

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio hacktoberfest difficulty: very hard fix is very hard in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 13, 2018
@thinkingserious
Copy link
Contributor

Hello @aroach,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

reedsa
reedsa approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@reedsa reedsa added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 26, 2018
@thinkingserious thinkingserious merged commit 57b4e7b into sendgrid:master Oct 29, 2018
@aroach aroach mentioned this pull request Oct 31, 2018
Closed
6 tasks
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

Assignees
No one assigned
Labels
difficulty: very hard fix is very hard in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Dockerized event webhook consumer
3 participants
@aroach @thinkingserious @reedsa