Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parser constructor error when passing payload #812

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Fix parser constructor error when passing payload #812

merged 1 commit into from
Dec 11, 2018

Conversation

valtlfelipe
Copy link
Contributor

Fixes #670

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fix parser constructor error when passing payload instead of body

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 18, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 18, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added hacktoberfest difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 30, 2018
@thinkingserious
Copy link
Contributor

Hello @valtlfelipe,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@aroach
Copy link
Contributor

aroach commented Oct 31, 2018

LGTM

@thinkingserious
Copy link
Contributor

Hello @valtlfelipe,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@thinkingserious thinkingserious merged commit fc1cb69 into sendgrid:master Dec 11, 2018
@thinkingserious
Copy link
Contributor

Hello @valtlfelipe,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parser constructor error
4 participants