Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve the mail package's README to handle the async send() #877

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

Berkmann18
Copy link
Contributor

I included the missing bits to handle the asynchronous send() call
including both ES6 and ES8 approaches.

Fixes

Closes #870

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

  • Adds the error handling for the send usage in the example in both ES6 (ES2015) and ES8 (ES2017).

I included the missing bits to handle the asynchronous `send()` call
including both ES6 and ES8 approaches which closes sendgrid#870.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 18, 2019
@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino changed the title Improved the mail package's README docs: Improve the mail package's README to handle the async send() Feb 13, 2020
@childish-sambino childish-sambino merged commit 8162318 into sendgrid:master Feb 13, 2020
@thinkingserious
Copy link
Contributor

Hello @Berkmann18,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@Berkmann18
Copy link
Contributor Author

@thinkingserious You're welcome :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to reflect use of promises.
3 participants