Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Mail Helper Refactor #434

Closed
thinkingserious opened this issue Sep 30, 2017 · 3 comments
Closed

PHP Mail Helper Refactor #434

thinkingserious opened this issue Sep 30, 2017 · 3 comments
Labels
difficulty: very hard fix is very hard in difficulty status: help wanted requesting help from the community type: getting started question while getting started type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

An interface to easily interact with the mail/send endpoint of the SendGrid v3 Web API.

The specification for this project is here and the discussion around this specification can be found here.

Acceptance Criteria

All of the use cases defined here are implemented and all corresponding tests are passing.

@COil
Copy link

COil commented Oct 23, 2017

Hi the rewrite is very welcome. When looking at this php class sendgrid/php-http-client/lib/SendGrid/Client.php for example it looks like PH4 code, no access modifier declared, properties declared dynamically, etc...

@mbernier mbernier removed difficulty: hard fix is hard in difficulty difficulty: medium fix is medium in difficulty difficulty: very hard fix is very hard in difficulty labels Oct 27, 2017
@thinkingserious
Copy link
Contributor Author

Please see this comment regarding making parameters optional.

@thinkingserious thinkingserious added difficulty: very hard fix is very hard in difficulty type: twilio enhancement feature request on Twilio's roadmap type: getting started question while getting started and removed type: community enhancement feature request not on Twilio's roadmap labels Feb 27, 2018
@thinkingserious
Copy link
Contributor Author

thinkingserious commented Apr 6, 2018

Hello Everyone!

@COil @zanderwar @caseyw @izhukovich @Tzafra @senorgeno @vitya1 @Braunson @cbschuld @paoga87 @Taluu @mazanax @ninsuo @ianh2 @WadeShuler @jaimehing @KnightAR

Development on the SendGrid PHP Mail Helper Refactor is underway on this branch. The example in sendmail.php is currently working on that branch.

The next step over the next few days is to implement the Kitchen Sink example and then implement the corresponding tests. I will then look at the issues that are linked (e.g. #321). Then, I should be able to release v7.0.0 shortly afterwards to Packagist.

Your feedback during this home stretch is greatly appreciated! I want to make sure we have a solid v7.0.0 base from which to iterate on.

Thanks!

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: very hard fix is very hard in difficulty status: help wanted requesting help from the community type: getting started question while getting started type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants