Update constructor to signify which parameters are required for sending all email #408
Conversation
thinkingserious
added
the
status: code review request
lib/helpers/mail/Mail.php
Outdated
| @@ -948,12 +948,18 @@ class Mail implements \JsonSerializable | |||
|
|
|||
| public function __construct($from = null, $subject = null, $to = null, $content = null) | |||
There was a problem hiding this comment.
I think we should remove the ability to set these to null since the helper will not work unless all of these parameters are set.
There was a problem hiding this comment.
What if the user wants to create the object and then add personalizations separately, e.g. for sending to many recipients?
There was a problem hiding this comment.
Also what about using transactional templates where the subject isn't set programmatically at all?
There was a problem hiding this comment.
@Tzafra,
Would you mind opening up a new issue so that we can get better visibility on this issue?
…them as required. This is based on Elmer's comments on PR sendgrid#408
|
Updated. The branch doesn't match the change so if you'd prefer a new PR let me know. |
|
Hello @caseyw, |
thinkingserious
changed the title
…ch parameters are required for sending all email
ghost
mentioned this pull request
|
Hello. |
No description provided.