Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Sending email with attachment' Use Case #275

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Add 'Sending email with attachment' Use Case #275

merged 1 commit into from
Mar 23, 2017

Conversation

ittus
Copy link
Contributor

@ittus ittus commented Nov 19, 2016

Add document for #270

Need to use base64.b64encode(data).decode() because in python3, b64encode returns bytes instead of string

Reference:
https://docs.python.org/2/library/base64.html
https://docs.python.org/3/library/base64.html

@thinkingserious
Copy link
Contributor

Hello @ittus,

Thank you for the PR!

We will be reviewing this PR soon, in the mean time, if you have not, please be sure to sign our CLA so that we can merge your changes. Thanks again!

Team DX

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio status: cla needed labels Nov 19, 2016
@andriisoldatenko
Copy link
Contributor

andriisoldatenko commented Nov 19, 2016

https://github.com/elbuo8/sendgrid-django/blob/master/sgbackend/mail.py#L110-L118
👍

@thinkingserious
Copy link
Contributor

Thanks again for the PR @ittus!

Please take a moment to fill out this form so that we may send you some swag :)

@thinkingserious thinkingserious merged commit 9086caf into sendgrid:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants