Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for password as buffer. Update some dependencies. #43

Merged
merged 3 commits into from
May 24, 2016
Merged

Added test for password as buffer. Update some dependencies. #43

merged 3 commits into from
May 24, 2016

Conversation

mirceaalexandru
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 23, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 82.224% when pulling 61dd157 on mirceaalexandru:buffer into afb684f on senecajs:master.

@mihaidma
Copy link
Contributor

LGTM

@mihaidma
Copy link
Contributor

@mcollina Are we inserting a vulnerability here?

Found some buffer related issue:
https://medium.com/node-js-javascript/important-security-upgrades-for-node-js-and-io-js-8ac14ece5852#.yuhturh1s
nodejs/node#4660

@coveralls
Copy link

coveralls commented May 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+9.1%) to 91.426% when pulling 8c9d3c3 on mirceaalexandru:buffer into afb684f on senecajs:master.

@coveralls
Copy link

coveralls commented May 24, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 82.24% when pulling dce07dd on mirceaalexandru:buffer into afb684f on senecajs:master.

@mihaidma
Copy link
Contributor

LGTM

@mirceaalexandru mirceaalexandru merged commit e8e4e09 into senecajs:master May 24, 2016
@mirceaalexandru mirceaalexandru deleted the buffer branch May 24, 2016 11:03
@mirceaalexandru mirceaalexandru mentioned this pull request May 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirceaalexandru @coveralls @mihaidma