Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Libsass 3.2.0 #12

Merged
merged 8 commits into from
Apr 7, 2015
Merged

[WIP] Libsass 3.2.0 #12

merged 8 commits into from
Apr 7, 2015

Conversation

chrinor2002
Copy link

An update to libsass 3.2.0. Currently this is beta, but the initial work has been done to bring the php module up to pay with the library. Once the official release comes out this should be able to be merged.

Warning! this contains the removal of the image_path. This is no longer available in libsass: sass/libsass#489

It is also worth mentioning sass/libsass#940. There is a "breaking" change that was introduced related to memory management. The general quick fix was to add a strdup() call before passing along the source. Without this there was a "pointer being freed was not allocated" error.

@chrinor2002
Copy link
Author

Looks like there is only one test still not passing:

parse_file_parses_file.diff:

003+   blah: "hello 4 world px bloon blah"; }
003-   blah: "hello 4 world px bloo\n blah"; }

scss:

blah: "hello #{2+2} world #{unit(23px)} #{'bloo\n'} blah";

Do we happen to know what sass-spec test that came from?

@pilif
Copy link
Member

pilif commented Apr 7, 2015

The test.scss comes from the original author who has since abandoned this. I have then run the same files against ruby sass before pushing it here in order to make sure that we generate the same code as ruby sass or, if we don't that we can be sure it's an issue in libsass itself (which it always was back then - the library was in horrible shape).

Current ruby sass produces the same output as you are seeing, so I would say we can just update the (nonesensical to begin with) test

@chrinor2002
Copy link
Author

Alright, assuming there is no other breaking issues before 3.2.0, we should be good to go once its released.

@pilif
Copy link
Member

pilif commented Apr 7, 2015

merging this now in preparation of the final release (which then will just be a submodule update).

Again, thanks a LOT for your contribution

pilif added a commit that referenced this pull request Apr 7, 2015
@pilif pilif merged commit ae00a9f into sensational:master Apr 7, 2015
@chrinor2002 chrinor2002 deleted the libsass3.2.0 branch April 7, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants