-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Libsass 3.2.0 #12
Conversation
…Sass_Output_Style in sass.h
…libsass3.2.0 Conflicts: src/php_sass.h src/sass.c
Looks like there is only one test still not passing: parse_file_parses_file.diff:
scss:
Do we happen to know what sass-spec test that came from? |
The test.scss comes from the original author who has since abandoned this. I have then run the same files against ruby sass before pushing it here in order to make sure that we generate the same code as ruby sass or, if we don't that we can be sure it's an issue in Current ruby |
Alright, assuming there is no other breaking issues before 3.2.0, we should be good to go once its released. |
merging this now in preparation of the final release (which then will just be a submodule update). Again, thanks a LOT for your contribution |
An update to libsass 3.2.0. Currently this is beta, but the initial work has been done to bring the php module up to pay with the library. Once the official release comes out this should be able to be merged.
Warning! this contains the removal of the image_path. This is no longer available in libsass: sass/libsass#489
It is also worth mentioning sass/libsass#940. There is a "breaking" change that was introduced related to memory management. The general quick fix was to add a strdup() call before passing along the source. Without this there was a "pointer being freed was not allocated" error.