Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove return type annotation #120

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix: Remove return type annotation #120

merged 1 commit into from
Apr 11, 2019

Conversation

localheinz
Copy link
Contributor

This PR

  • removes a return type annotation

💁‍♂️ The implementation within this repository doesn't return anything, and probably no other implementation does.

BehatPageObjectExtension/src/Context/PageObjectContext.php

Lines 49 to 55 in 163c768

/**
* @param PageObjectFactory $pageObjectFactory
*/
public function setPageObjectFactory(PageObjectFactory $pageObjectFactory)
{
$this->pageObjectFactory = $pageObjectFactory;
}

@DonCallisto
Copy link
Contributor

LGTM

@jakzal jakzal merged commit c649484 into sensiolabs:master Apr 11, 2019
@localheinz localheinz deleted the fix/type branch April 11, 2019 15:03
@localheinz
Copy link
Contributor Author

Thank you, @DonCallisto and @jakzal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @DonCallisto @jakzal