Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows colors in sensuctl #2922

Merged
merged 6 commits into from
May 7, 2019
Merged

Fix Windows colors in sensuctl #2922

merged 6 commits into from
May 7, 2019

Conversation

amdprophet
Copy link
Member

What is this change?

Fixes color formatting in sensuctl on Windows.

Why is this change necessary?

Fixes #2906.

Does your change need a Changelog entry?

Yup, updated.

How did you verify this change?

Tested on Windows using both powershell and cmd.exe.

image

image

amdprophet added 2 commits May 6, 2019 17:32
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you fix the test. Nice work!

amdprophet added 2 commits May 6, 2019 17:57
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
Copy link
Contributor

@jamesdphillips jamesdphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

amdprophet added 2 commits May 6, 2019 18:23
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
@amdprophet
Copy link
Member Author

Updated the colours on Windows so that they look good on both cmd.exe and ps.exe.

image

image

@amdprophet amdprophet merged commit d685b7c into master May 7, 2019
@amdprophet amdprophet deleted the windows-colors branch May 7, 2019 01:36
amdprophet added a commit that referenced this pull request May 8, 2019
@amdprophet amdprophet restored the windows-colors branch June 18, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sensuctl tabular output looks terrible on some versions of Windows
3 participants