Fix .dropdown-menu height and add y-overflow #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .dropdown-menu class doesn't take into account a potential higher number of list items.
For example, I'm using (at the moment) more than 100 subscriptions which completely messes up the UI when you open the Subscriptions pop-up in the Clients' page.
To reproduce this problem, just add a considerable amount of subscriptions (or even DCs, which is crazy but I don't know other people's use-cases) and see the UI all messed up with a long Y-scroll.
This Pull Request simply adds a maximum height of 600px (which I think it's a reasonable number considering today's screen resolutions) and an automatic overflow of the y-axis, creating a y-scroll bar.
Cheers 😃