This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
Allow to build uchiwa packages in docker #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
=======================================
Coverage 22.39% 22.39%
=======================================
Files 28 28
Lines 2353 2353
=======================================
Hits 527 527
Misses 1766 1766
Partials 60 60Continue to review full report at Codecov.
|
SergK
force-pushed
the
build_packages_in_docker
branch
from
6ac8a07 to
2f7a516
Compare
|
@palourde hi, can you please review PR? Thank you |
yakirgb
reviewed
Sep 30, 2017
There was a problem hiding this comment.
About readme file, maybe Uchiwa Docs is better place to examples.
SergK
force-pushed
the
build_packages_in_docker
branch
from
2f7a516 to
fcab61f
Compare
|
@SergK As mentioned, could you remove the documentation in the README and open a PR against https://github.com/palourde/uchiwa-docs instead? Thanks! |
SergK
force-pushed
the
build_packages_in_docker
branch
from
fcab61f to
1463ae4
Compare
|
@palourde rebased on latest master and updated docs palourde/uchiwa-docs#14 |
It's really helpful to have an ability to build uchiwa package in docker image, without installing additional dependencies on host system
SergK
force-pushed
the
build_packages_in_docker
branch
from
1463ae4 to
6e4251d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really helpful to have an ability to build uchiwa package
in docker image, without installing additional dependencies on
host system
Description
Allow to build uchiwa package in docker
Related Issue
Motivation and Context
We need to have ability for simple uchiwa packaging
How Has This Been Tested?
No changes in code itself, just additional feature with two docker commands:
Screenshots (if appropriate):
Types of changes
Checklist: