This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
Fix segfault on unresponsive APIs #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
echlebek
reviewed
Jun 11, 2018
| @@ -42,7 +42,7 @@ type DatacenterSnapshot struct { | |||
| Checks []interface{} | |||
| Clients []interface{} | |||
| Events []interface{} | |||
| Info structs.Info | |||
| Info *structs.Info | |||
There was a problem hiding this comment.
Why make this a pointer? Not saying it's wrong to have a pointer here, just curious about the reasoning.
There was a problem hiding this comment.
I made it a pointer so that it can be assigned & checked for a nil value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Kolberg amd.prophet@gmail.com
Description
Fixes a segfault when there are one or more unresponsive APIs.
Related Issue
Fixes #786.
Motivation and Context
Uchiwa should not be segfaulting.
How Has This Been Tested?
Tested locally by stopping the Sensu API. Uchiwa backend no longer segfaults and errors are appropriately displayed on the frontend.
Types of changes
Checklist: