Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

Fix for only one silenced entry showing up #788

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Conversation

amdprophet
Copy link
Member

Signed-off-by: Justin Kolberg amd.prophet@gmail.com

Description

Fixes a bug where a maximum of one silenced entry will ever appear.

Related Issue

Fixes #785

Motivation and Context

N/A

How Has This Been Tested?

Tested locally. More than one silenced entry will now appear.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
Copy link

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement

@amdprophet amdprophet merged commit 8fe5a98 into master Jun 11, 2018
@amdprophet amdprophet deleted the fix-silenced branch June 11, 2018 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one silenced entry per DC is displayed
2 participants