Skip to content

Commit

Permalink
feat(sentry): Add missing --no-strict-offset-reset and --auto-offset-…
Browse files Browse the repository at this point in the history
…reset for consumers (#1535)
  • Loading branch information
adonskoy authored Oct 13, 2024
1 parent 33d9945 commit 8e0eea0
Show file tree
Hide file tree
Showing 33 changed files with 180 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ spec:
- "ingest-attachments"
- "--consumer-group"
- "ingest-consumer"
{{- if .Values.sentry.ingestConsumerAttachments.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.ingestConsumerAttachments.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.ingestConsumerAttachments.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ spec:
- "ingest-events"
- "--consumer-group"
- "ingest-consumer"
{{- if .Values.sentry.ingestConsumerEvents.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.ingestConsumerEvents.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.ingestConsumerEvents.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ spec:
- "ingest-monitors"
- "--consumer-group"
- "ingest-monitors"
{{- if .Values.sentry.ingestMonitors.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.ingestMonitors.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.ingestMonitors.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.ingestMonitors.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ spec:
- "ingest-occurrences"
- "--consumer-group"
- "ingest-occurrences"
{{- if .Values.sentry.ingestOccurrences.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.ingestOccurrences.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.ingestOccurrences.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.ingestOccurrences.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ spec:
- "ingest-profiles"
- "--consumer-group"
- "ingest-profiles"
{{- if .Values.sentry.ingestProfiles.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.ingestProfiles.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.ingestProfiles.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.ingestProfiles.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ spec:
- "ingest-replay-recordings"
- "--consumer-group"
- "ingest-replay-recordings"
{{- if .Values.sentry.ingestReplayRecordings.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.ingestReplayRecordings.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.ingestReplayRecordings.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.ingestReplayRecordings.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ spec:
- "ingest-transactions"
- "--consumer-group"
- "ingest-consumer"
{{- if .Values.sentry.ingestConsumerTransactions.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.ingestConsumerTransactions.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.ingestConsumerTransactions.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ spec:
- "billing-metrics-consumer"
- "--consumer-group"
- "billing-metrics-consumer"
{{- if .Values.sentry.billingMetricsConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.billingMetricsConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.billingMetricsConsumer.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.billingMetricsConsumer.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ spec:
- "ingest-metrics"
- "--consumer-group"
- "metrics-consumer"
{{- if .Values.sentry.metricsConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.metricsConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.metricsConsumer.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.metricsConsumer.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ spec:
- "run"
- "consumer"
- "ingest-generic-metrics"
{{- if .Values.sentry.genericMetricsConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.genericMetricsConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.genericMetricsConsumer.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,11 @@ spec:
- "post-process-forwarder"
- "--synchronize-commit-log-topic=snuba-commit-log"
- "--synchronize-commit-group=snuba-consumers"
{{- if .Values.sentry.postProcessForwardTransactions.noStrictOffsetReset }}
{{- if .Values.sentry.postProcessForwardErrors.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.postProcessForwardErrors.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.postProcessForwardErrors.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.postProcessForwardErrors.livenessProbe.enabled }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ spec:
- "--synchronize-commit-log-topic=snuba-generic-events-commit-log"
- "--synchronize-commit-group"
- "generic_events_group"
{{- if .Values.sentry.postProcessForwardIssuePlatform.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.postProcessForwardIssuePlatform.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.postProcessForwardIssuePlatform.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ spec:
- "--synchronize-commit-log-topic=snuba-transactions-commit-log"
- "--synchronize-commit-group"
- "transactions_group"
{{- if .Values.sentry.postProcessForwardTransactions.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.postProcessForwardTransactions.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.postProcessForwardTransactions.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@ spec:
- "run"
- "consumer"
- "events-subscription-results"
{{- if .Values.sentry.subscriptionConsumerEvents.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.subscriptionConsumerEvents.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.subscriptionConsumerEvents.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
- "--consumer-group"
- "query-subscription-consumer"
{{- if .Values.sentry.subscriptionConsumerEvents.livenessProbe.enabled }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ spec:
- "generic-metrics-subscription-results"
- "--consumer-group"
- "query-subscription-consumer"
{{- if .Values.sentry.subscriptionConsumerGenericMetrics.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.subscriptionConsumerGenericMetrics.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.subscriptionConsumerGenericMetrics.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.subscriptionConsumerGenericMetrics.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ spec:
- "metrics-subscription-results"
- "--consumer-group"
- "query-subscription-consumer"
{{- if .Values.sentry.subscriptionConsumerMetrics.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.subscriptionConsumerMetrics.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.subscriptionConsumerMetrics.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.subscriptionConsumerMetrics.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ spec:
- "transactions-subscription-results"
- "--consumer-group"
- "query-subscription-consumer"
{{- if .Values.sentry.subscriptionConsumerTransactions.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.sentry.subscriptionConsumerTransactions.autoOffsetReset }}"
{{- end }}
{{- if .Values.sentry.subscriptionConsumerTransactions.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- if .Values.sentry.subscriptionConsumerTransactions.livenessProbe.enabled }}
- "--healthcheck-file-path"
- "/tmp/health.txt"
Expand Down
2 changes: 2 additions & 0 deletions charts/sentry/templates/snuba/deployment-snuba-consumer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "errors"
- "--consumer-group"
- "snuba-consumers"
{{- if .Values.snuba.consumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.consumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.consumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.consumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "generic_metrics_counters_raw"
- "--consumer-group"
- "snuba-gen-metrics-counters-consumers"
{{- if .Values.snuba.genericMetricsCountersConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.genericMetricsCountersConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.genericMetricsCountersConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.genericMetricsCountersConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "generic_metrics_distributions_raw"
- "--consumer-group"
- "snuba-gen-metrics-distributions-consumers"
{{- if .Values.snuba.genericMetricsDistributionConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.genericMetricsDistributionConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.genericMetricsDistributionConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.genericMetricsDistributionConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "generic_metrics_sets_raw"
- "--consumer-group"
- "snuba-gen-metrics-sets-consumers"
{{- if .Values.snuba.genericMetricsSetsConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.genericMetricsSetsConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.genericMetricsSetsConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.genericMetricsSetsConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "group_attributes"
- "--consumer-group"
- "snuba-group-attributes-group"
{{- if .Values.snuba.groupAttributesConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.groupAttributesConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.groupAttributesConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.groupAttributesConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "search_issues"
- "--consumer-group"
- "generic_events_group"
{{- if .Values.snuba.issueOccurrenceConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.issueOccurrenceConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.issueOccurrenceConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.issueOccurrenceConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "metrics_raw"
- "--consumer-group"
- "snuba-metrics-consumers"
{{- if .Values.snuba.metricsConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.metricsConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.metricsConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.metricsConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "outcomes_raw"
- "--consumer-group"
- "snuba-consumers"
{{- if .Values.snuba.outcomesBillingConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.outcomesBillingConsumer.autoOffsetReset }}"
{{- end }}
- "--raw-events-topic"
- "outcomes-billing"
{{- if .Values.snuba.outcomesBillingConsumer.maxBatchSize }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "outcomes_raw"
- "--consumer-group"
- "snuba-consumers"
{{- if .Values.snuba.outcomesConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.outcomesConsumer.autoOffsetReset }}"
{{- end }}
- "--max-batch-size"
- "{{ default "3" .Values.snuba.outcomesConsumer.maxBatchSize }}"
{{- if .Values.snuba.outcomesConsumer.processes }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "functions_raw"
- "--consumer-group"
- "functions_raw_group"
{{- if .Values.snuba.profilingFunctionsConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.profilingFunctionsConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.profilingFunctionsConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.profilingFunctionsConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "profiles"
- "--consumer-group"
- "profiles_group"
{{- if .Values.snuba.profilingProfilesConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.profilingProfilesConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.profilingProfilesConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.profilingProfilesConsumer.maxBatchSize }}"
Expand Down
2 changes: 2 additions & 0 deletions charts/sentry/templates/snuba/deployment-snuba-replacer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ spec:
- "replacer"
- "--storage"
- "errors"
{{- if .Values.snuba.replacer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.replacer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.replacer.maxBatchTimeMs }}
- "--max-batch-time-ms"
- "{{ .Values.snuba.replacer.maxBatchTimeMs }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "replays"
- "--consumer-group"
- "replays_group"
{{- if .Values.snuba.replaysConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.replaysConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.replaysConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.replaysConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "spans"
- "--consumer-group"
- "snuba-spans-group"
{{- if .Values.snuba.spansConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.spansConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.spansConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.spansConsumer.maxBatchSize }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ spec:
- "transactions"
- "--consumer-group"
- "transactions_group"
{{- if .Values.snuba.transactionsConsumer.autoOffsetReset }}
- "--auto-offset-reset"
- "{{ .Values.snuba.transactionsConsumer.autoOffsetReset }}"
{{- end }}
{{- if .Values.snuba.transactionsConsumer.maxBatchSize }}
- "--max-batch-size"
- "{{ .Values.snuba.transactionsConsumer.maxBatchSize }}"
Expand Down
Loading

0 comments on commit 8e0eea0

Please sign in to comment.