feat: Allow to set max_suspicious_broken_parts in merge_tree settings… #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mokto
approved these changes
Nov 27, 2023
mzglinski
reviewed
Nov 28, 2023
| @@ -165,6 +165,7 @@ data: | |||
| <parts_to_delay_insert>{{ .Values.clickhouse.configmap.merge_tree.parts_to_delay_insert }}</parts_to_delay_insert> | |||
| <parts_to_throw_insert>{{ .Values.clickhouse.configmap.merge_tree.parts_to_throw_insert }}</parts_to_throw_insert> | |||
| <max_part_loading_threads>{{ .Values.clickhouse.configmap.merge_tree.max_part_loading_threads }}</max_part_loading_threads> | |||
| <max_suspicious_broken_parts>100</max_suspicious_broken_parts> | |||
| </merge_tree> | |||
There was a problem hiding this comment.
This shouldn't be hardcoded.
There was a problem hiding this comment.
You're right, I will fix it.
There was a problem hiding this comment.
Possible to push a change for this?
This was referenced Apr 12, 2024
Merged
Merged
This was referenced Apr 21, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days ago I faced a problem in one of our clickhouse replicas. When clickhouse tries to init db it needs to merge broken parts of data to a single partition and it needs to delete those files afterward. If the number of those files exceeded the number set in the configuration it denied deletion (here) and db doesn't init, so what we need to do is increase the max_suspicious_broken_parts value to cover those broken file numbers.
Unfortunately, it is not possible to set the above settings via chart values so I decided to add handling these specific params.