Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to set max_suspicious_broken_parts in merge_tree settings… #1080

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat: Allow to set max_suspicious_broken_parts in merge_tree settings… #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f27ab70
feat: Allow to set max_suspicious_broken_parts in merge_tree settings…
mrouhi13 Nov 24, 2023
aef6b3f
increase minor version
mrouhi13 Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clickhouse/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ keywords:
name: clickhouse
sources:
- https://github.com/sentry-kubernetes/charts
version: 3.5.0
version: 3.6.0
maintainers:
- name: sentry-kubernetes
1 change: 1 addition & 0 deletions clickhouse/templates/configmap-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ data:
<parts_to_delay_insert>{{ .Values.clickhouse.configmap.merge_tree.parts_to_delay_insert }}</parts_to_delay_insert>
<parts_to_throw_insert>{{ .Values.clickhouse.configmap.merge_tree.parts_to_throw_insert }}</parts_to_throw_insert>
<max_part_loading_threads>{{ .Values.clickhouse.configmap.merge_tree.max_part_loading_threads }}</max_part_loading_threads>
<max_suspicious_broken_parts>100</max_suspicious_broken_parts>
</merge_tree>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be hardcoded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I will fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible to push a change for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR created.

{{- end }}
</yandex>
Expand Down
2 changes: 2 additions & 0 deletions clickhouse/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,8 @@ clickhouse:
parts_to_throw_insert: 300
# The maximum number of threads that read parts when ClickHouse starts.
max_part_loading_threads: auto
# If the number of broken parts in a single partition exceeds the max_suspicious_broken_parts value, automatic deletion is denied.
max_suspicious_broken_parts: 100

##
## Web interface for ClickHouse in the Tabix project.
Expand Down
Loading