Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally set auto-offset-reset for snuba subscription consumers #1538

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

patsevanton
Copy link
Contributor

@patsevanton patsevanton commented Oct 14, 2024

Description

This pull request addresses an issue where the auto-offset-reset parameter was being unconditionally set for Snuba subscription consumers, even when the value was not explicitly defined in the configuration. This could lead to unintended behavior and potential errors.

To resolve this, I've added a conditional check to ensure that the auto-offset-reset parameter is only included in the command if it is explicitly defined in the values configuration. This change applies to the following Snuba subscription consumer deployments:

  • deployment-snuba-subscription-consumer-events.yaml
  • deployment-snuba-subscription-consumer-metrics.yaml
  • deployment-snuba-subscription-consumer-transactions.yaml

Changes Made

  • Added a conditional check around the auto-offset-reset parameter in the command section of each deployment template.
  • The parameter is now only included if the corresponding value is defined in the values.yaml file.

Related Issues

Related Pull Requests:

@Mokto Please review and let me know if there are any additional changes or improvements needed.

Thank you!

@Mokto Mokto merged commit db26b85 into sentry-kubernetes:develop Oct 14, 2024
2 checks passed
@Mokto Mokto mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants