fix: conditionally set auto-offset-reset for snuba subscription consumers #1538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue where the
auto-offset-reset
parameter was being unconditionally set for Snuba subscription consumers, even when the value was not explicitly defined in the configuration. This could lead to unintended behavior and potential errors.To resolve this, I've added a conditional check to ensure that the
auto-offset-reset
parameter is only included in the command if it is explicitly defined in the values configuration. This change applies to the following Snuba subscription consumer deployments:deployment-snuba-subscription-consumer-events.yaml
deployment-snuba-subscription-consumer-metrics.yaml
deployment-snuba-subscription-consumer-transactions.yaml
Changes Made
auto-offset-reset
parameter in the command section of each deployment template.values.yaml
file.Related Issues
Related Pull Requests:
@Mokto Please review and let me know if there are any additional changes or improvements needed.
Thank you!