Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rabbitmq): updated configuration to support Prometheus #1578

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

patsevanton
Copy link
Contributor

@patsevanton patsevanton commented Oct 25, 2024

Description

This pull request introduces the addition of RabbitMQ metrics configuration in the values.yaml file, although the metrics are disabled by default. Additionally, it removes empty lines from the configuration for better readability.

Changes Made

  • RabbitMQ Configuration:
    • Added metrics section with enabled, serviceMonitor, path, and labels configurations.
    • Disabled metrics collection by default (metrics.enabled: false).
    • Removed empty lines in the configuration.

Please review the changes and provide feedback. If everything looks good, feel free to merge this pull request.

Thank you!

@patsevanton
Copy link
Contributor Author

k get pod -n test

NAME                                                              READY   STATUS    RESTARTS      AGE
sentry-billing-metrics-consumer-68c96c49f4-8jvph                  1/1     Running   0             59s
sentry-clickhouse-0                                               1/1     Running   0             12m
sentry-cron-5bdc5f8dc9-4m6nl                                      1/1     Running   2 (12m ago)   12m
sentry-generic-metrics-consumer-5c4d7467c8-fsr7r                  1/1     Running   0             59s
sentry-ingest-consumer-attachments-6958c9d99d-pg6d6               1/1     Running   0             58s
sentry-ingest-consumer-events-7dff4467b7-gggx8                    1/1     Running   0             57s
sentry-ingest-consumer-transactions-697848b7f-rgfvn               1/1     Running   0             57s
sentry-ingest-monitors-c59cc98cd-p756l                            1/1     Running   0             56s
sentry-ingest-occurrences-85f65f65b6-cknhp                        1/1     Running   0             55s
sentry-ingest-replay-recordings-bc8d5b6bb-nf5wn                   1/1     Running   0             54s
sentry-issue-occurrence-consumer-85b545496c-28kv4                 1/1     Running   0             38s
sentry-kafka-controller-0                                         1/1     Running   0             12m
sentry-kafka-controller-1                                         1/1     Running   0             12m
sentry-kafka-controller-2                                         1/1     Running   0             12m
sentry-metrics-consumer-6f6fc8fdcd-kcv6x                          1/1     Running   0             53s
sentry-nginx-7bb968f688-h875t                                     1/1     Running   0             12m
sentry-post-process-forward-errors-57487778dc-82npr               1/1     Running   0             52s
sentry-post-process-forward-issue-platform-5884bb66-fqxr2         1/1     Running   0             51s
sentry-post-process-forward-transactions-5bf6d864d6-65k6s         1/1     Running   0             50s
sentry-rabbitmq-0                                                 1/1     Running   0             12m
sentry-relay-5c5689855b-dtb2k                                     1/1     Running   0             34s
sentry-sentry-postgresql-0                                        1/1     Running   0             12m
sentry-sentry-redis-master-0                                      1/1     Running   0             12m
sentry-sentry-redis-replicas-0                                    1/1     Running   1 (11m ago)   12m
sentry-snuba-api-cb6f47f66-8lfzk                                  1/1     Running   0             12m
sentry-snuba-consumer-85c5f6b9c-tk7v9                             1/1     Running   0             49s
sentry-snuba-generic-metrics-counters-consumer-64688445c-7dsrz    1/1     Running   0             45s
sentry-snuba-generic-metrics-distributions-consumer-77ccf5cmvpb   1/1     Running   0             45s
sentry-snuba-generic-metrics-sets-consumer-6754bf8b77-w57ws       1/1     Running   0             44s
sentry-snuba-group-attributes-consumer-7bf8f89c47-tdg2f           1/1     Running   0             43s
sentry-snuba-metrics-consumer-5bf57b5776-6976d                    1/1     Running   0             42s
sentry-snuba-outcomes-billing-consumer-5c54578845-vv8g7           1/1     Running   0             41s
sentry-snuba-outcomes-consumer-7fd9b7bfd4-lv2zc                   1/1     Running   0             38s
sentry-snuba-replacer-5d7d547476-jwswn                            1/1     Running   0             37s
sentry-snuba-replays-consumer-7dbb575bfd-87qfn                    1/1     Running   0             41s
sentry-snuba-spans-consumer-77cf4c4d87-8rpf9                      1/1     Running   0             40s
sentry-snuba-subscription-consumer-events-796bfffc75-tc2hm        1/1     Running   0             36s
sentry-snuba-subscription-consumer-metrics-7d77dfdbd4-bxkct       1/1     Running   0             35s
sentry-snuba-subscription-consumer-transactions-556496dc6cmjbh4   1/1     Running   0             35s
sentry-snuba-transactions-consumer-798bcdd8bf-429qz               1/1     Running   0             39s
sentry-subscription-consumer-events-56cbbb569d-9gfhw              1/1     Running   0             49s
sentry-subscription-consumer-generic-metrics-6785bb66cf-xzdxz     1/1     Running   0             48s
sentry-subscription-consumer-metrics-7f6c774979-zc8vq             1/1     Running   0             47s
sentry-subscription-consumer-transactions-6fc8847cfd-rrlvt        1/1     Running   0             46s
sentry-web-68478c8d7f-lktld                                       1/1     Running   2 (11m ago)   12m
sentry-worker-58788dd48-56bx7                                     1/1     Running   2 (12m ago)   12m
sentry-zookeeper-clickhouse-0                                     1/1     Running   0             12m

@Mokto Mokto merged commit 35f779a into sentry-kubernetes:develop Oct 25, 2024
2 of 3 checks passed
@Mokto Mokto mentioned this pull request Oct 25, 2024
@patsevanton patsevanton deleted the rabbitmq-metrics branch December 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants