fix: allow Redis only and fix Redis password use in BROKER_URL #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an enabled setting for RabbitMQ and Redis so the user can choose what to use.
Updates Sentry configmap to set redis as Broker URL if no RabbitMQ is deployed.
Updates Redis worker deployment to include the password when set
When RabbitMQ is disabled, use Redis connection string as BROKER_URL for the Sentry cron.
|
Amazing! Thanks. I'll put my comments right away |
Mokto
requested changes
Mar 4, 2020
| BROKER_URL = os.environ.get("BROKER_URL", "amqp://{{ .Values.rabbitmq.username }}:{{ .Values.rabbitmq.password }}@{{ .Values.rabbitmq.host }}:5672//") | ||
| {{- else if .Values.redis.enabled }} | ||
| {{- if .Values.redis.password }} |
There was a problem hiding this comment.
This is repeated, could you use a template helper instead?
Thanks.
There was a problem hiding this comment.
I changed this, since Redis is always enabled. Since I'm fairly new to helm charts, I'm not sure how to write helpers yet. But I could take a look at it.
Simplifies some if/else conditions, since Redis is always enabled. Also remove redis.enabled setting from values.
|
Thanks ! That's perfect. Could you just activate rabbitmq per default, please ? |
|
Of course. |
|
No, not yet ! Go for it ;) I'll merge your PR in the early evening. Thanks for your work ! |
This was referenced Apr 12, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to skip the deployment of RabbitMQ and therefore skip the deployment of the Sentry worker that connects to it.
This also fixes the Sentry Redis Worker, so that the correct BROKER_URL is used, when Redis is configured to connect with password.
This also updates the Sentry configmap to set the Broker URL to a Redis connection string, if RabbitMQ is disabled.