Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra quotation mark in ConfigMap #415

Merged
merged 5 commits into from
Jul 5, 2021
Merged

Remove extra quotation mark in ConfigMap #415

merged 5 commits into from
Jul 5, 2021

Conversation

Reshet-GoIT
Copy link
Contributor

Due to this quotation mark, GitHub integration does not work, Sentry fails with "Could not deserialize key data" error

@Reshet-GoIT
Copy link
Contributor Author

@Mokto Please, review this change as it blocks our work

@Mokto
Copy link
Contributor

Mokto commented Jul 5, 2021

Sorry about the delay.

I had to add this hack, without it doesn't work.

This works for me :


  github:
    appId: "1234"
    appName: MyApp
    clientId: "yyy"
    clientSecret: "XXX"
    privateKey: "-----BEGIN RSA PRIVATE KEY-----\nAAAAAAA\BBBBB==\n-----END RSA PRIVATE KEY-----\n"
    webhookSecret: "XXXX"

@Reshet-GoIT
Copy link
Contributor Author

@Mokto could you try with my latest changes? It works for me, but it doesn't work with your hack with extra quotation

@Mokto
Copy link
Contributor

Mokto commented Jul 5, 2021

Trying now. Thanks!

@Mokto Mokto merged commit 44cea73 into sentry-kubernetes:develop Jul 5, 2021
This was referenced Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants