Fix: issue-532. Snuba using incorrect kafka topic/group. #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mokto Any comments on this? This is quite important fix and it wasn't included in 13.0.0 for some reason. |
|
Thanks. Pushing it as 13.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe snuba was using the wrong queue for transactions subscription, making it conflict with the events queue, causing things to get blocked up.
I've set it to use what I believe is the right one. This seems to work well for me.
This is my first sentry PR, I think this is right, but can someone verify this is correct? :)
Let me know if I need to do anything else.
#532