Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templating error when disabling hooks #76

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

joscha-alisch
Copy link
Contributor

Currently when disabling the hooks via

hooks:
  enabled: false

helm upgrade fails due to snuba-db-init and snuba-migrate still containing some yaml data.

---
# Source: sentry/templates/hooks/snuba-db-init.job.yaml
volumes:
        - name: config
          configMap:
            name: sentry-snuba
---
# Source: sentry/templates/hooks/snuba-migrate.job.yaml
volumes:
        - name: config
          configMap:
            name: sentry-snuba

This PR fixes that by actually removing the complete resource when setting enabled=false.

@Mokto
Copy link
Contributor

Mokto commented Jun 4, 2020

Thanks! Could you update the patch version please ?

@joscha-alisch
Copy link
Contributor Author

Yep, sorry wasn't sure if you would want to do this :)

@Mokto Mokto merged commit f0a8e3f into sentry-kubernetes:develop Jun 4, 2020
@Mokto
Copy link
Contributor

Mokto commented Jun 4, 2020

Thanks !!

This was referenced Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants