This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 88
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
11 changed files
with
259 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
@import "./settings-dialog/settings-dialog-theme"; | ||
|
||
@mixin gd-settings-all-theme($theme) { | ||
@include gd-settings-dialog-theme($theme); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
export * from './settings.module'; | ||
export * from './settings-context'; | ||
export * from './settings-registry'; | ||
export * from './settings-dialog/settings-dialog.component'; | ||
export * from './settings-dialog/settings-dialog'; |
11 changes: 11 additions & 0 deletions
11
src/browser/settings/settings-dialog/_settings-dialog-theme.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
@import "../../ui/style/theming"; | ||
|
||
@mixin gd-settings-dialog-theme($theme) { | ||
$foreground: map-get($theme, foreground); | ||
|
||
.SettingsDialog { | ||
&__content > gd-tab-group { | ||
border-bottom: 1px solid gd-color($foreground, divider); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export interface SettingsDialogData { | ||
initialSettingId?: string; | ||
} |
17 changes: 17 additions & 0 deletions
17
src/browser/settings/settings-dialog/settings-dialog.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<gd-dialog-header fxLayout fxLayoutAlign="space-between center"> | ||
<h1 gdDialogTitle>{{ title }}</h1> | ||
<button gd-icon-button aria-label="Close settings" (click)="closeThisDialog()" id="settings-dialog-close-button"> | ||
<gd-icon name="close"></gd-icon> | ||
</button> | ||
</gd-dialog-header> | ||
|
||
<gd-dialog-content class="SettingsDialog__content"> | ||
<gd-tab-group [tabControl]="tabControl"></gd-tab-group> | ||
<div [ngSwitch]="tabControl.activateTab?.value" class="SettingsDialog__container"> | ||
<ng-container *ngFor="let context of settingContexts"> | ||
<div *ngSwitchCase="context.id" class="SettingsDialog__tabContent"> | ||
<ng-container *ngComponentOutlet="context.component; injector: _injector"></ng-container> | ||
</div> | ||
</ng-container> | ||
</div> | ||
</gd-dialog-content> |
14 changes: 14 additions & 0 deletions
14
src/browser/settings/settings-dialog/settings-dialog.component.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
@import "../../ui/style/spacing"; | ||
|
||
.SettingsDialog { | ||
&__content { | ||
padding: 0 !important; | ||
} | ||
|
||
&__container { | ||
padding: $spacing; | ||
} | ||
|
||
&__tabContent { | ||
} | ||
} |
108 changes: 108 additions & 0 deletions
108
src/browser/settings/settings-dialog/settings-dialog.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
import { NgModule } from '@angular/core'; | ||
import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
import { By } from '@angular/platform-browser'; | ||
import { fastTestSetup, NoopComponent } from '../../../../test/helpers'; | ||
import { MockDialog, MockDialogRef } from '../../../../test/mocks/browser'; | ||
import { DialogRef } from '../../ui/dialog'; | ||
import { UiModule } from '../../ui/ui.module'; | ||
import { SettingsContext } from '../settings-context'; | ||
import { SETTINGS_REGISTRATION, SettingsRegistry } from '../settings-registry'; | ||
import { SettingsDialogData } from './settings-dialog-data'; | ||
import { SettingsDialogComponent } from './settings-dialog.component'; | ||
|
||
|
||
describe('browser.settings.SettingsDialogComponent', () => { | ||
let component: SettingsDialogComponent; | ||
let fixture: ComponentFixture<SettingsDialogComponent>; | ||
|
||
let mockDialogRef: MockDialogRef<SettingsDialogComponent, SettingsDialogData, void>; | ||
|
||
let registry: SettingsRegistry; | ||
const registration: SettingsContext<any>[] = [ | ||
{ | ||
id: 'settings-1', | ||
tabName: 'Settings1', | ||
component: NoopComponent, | ||
}, | ||
{ | ||
id: 'settings-2', | ||
tabName: 'Settings2', | ||
component: NoopComponent, | ||
}, | ||
{ | ||
id: 'settings-3', | ||
tabName: 'Settings3', | ||
component: NoopComponent, | ||
}, | ||
]; | ||
|
||
@NgModule({ | ||
declarations: [NoopComponent], | ||
entryComponents: [NoopComponent], | ||
exports: [NoopComponent], | ||
}) | ||
class NoopModuleWithEntries { | ||
} | ||
|
||
fastTestSetup(); | ||
|
||
beforeAll(async () => { | ||
mockDialogRef = new MockDialogRef(new MockDialog(), SettingsDialogComponent); | ||
|
||
await TestBed | ||
.configureTestingModule({ | ||
imports: [ | ||
UiModule, | ||
NoopModuleWithEntries, | ||
], | ||
providers: [ | ||
SettingsRegistry, | ||
{ provide: SETTINGS_REGISTRATION, useValue: registration }, | ||
{ provide: DialogRef, useValue: mockDialogRef }, | ||
], | ||
declarations: [ | ||
SettingsDialogComponent, | ||
], | ||
}) | ||
.compileComponents(); | ||
}); | ||
|
||
beforeEach(() => { | ||
registry = TestBed.get(SettingsRegistry); | ||
|
||
fixture = TestBed.createComponent(SettingsDialogComponent); | ||
component = fixture.componentInstance; | ||
component.data = {}; | ||
}); | ||
|
||
afterEach(() => { | ||
registry.ngOnDestroy(); | ||
}); | ||
|
||
it('should select first tab by default.', () => { | ||
fixture.detectChanges(); | ||
expect(component.tabControl.activateTab.value).toEqual('settings-1'); | ||
}); | ||
|
||
it('should select initial setting id if it provided.', () => { | ||
component.data = { initialSettingId: 'settings-3' }; | ||
fixture.detectChanges(); | ||
|
||
expect(component.tabControl.activateTab.value).toEqual('settings-3'); | ||
}); | ||
|
||
it('should close dialog when click close button.', () => { | ||
const closeCallback = jasmine.createSpy('close callback'); | ||
const subscription = mockDialogRef.afterClosed().subscribe(closeCallback); | ||
|
||
fixture.detectChanges(); | ||
|
||
const closeButtonEl = fixture.debugElement.query( | ||
By.css('button#settings-dialog-close-button'), | ||
).nativeElement as HTMLButtonElement; | ||
closeButtonEl.click(); | ||
|
||
expect(closeCallback).toHaveBeenCalled(); | ||
subscription.unsubscribe(); | ||
}); | ||
}); |
45 changes: 45 additions & 0 deletions
45
src/browser/settings/settings-dialog/settings-dialog.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { Component, Inject, Injector, OnInit, Optional } from '@angular/core'; | ||
import { __DARWIN__ } from '../../../libs/platform'; | ||
import { DIALOG_DATA, DialogRef } from '../../ui/dialog'; | ||
import { TabControl } from '../../ui/tabs/tab-control'; | ||
import { SettingsContext } from '../settings-context'; | ||
import { SettingsRegistry } from '../settings-registry'; | ||
import { SettingsDialogData } from './settings-dialog-data'; | ||
|
||
|
||
@Component({ | ||
selector: 'gd-settings-dialog', | ||
templateUrl: './settings-dialog.component.html', | ||
styleUrls: ['./settings-dialog.component.scss'], | ||
}) | ||
export class SettingsDialogComponent implements OnInit { | ||
readonly title = __DARWIN__ ? 'Preferences' : 'Settings'; | ||
readonly settingContexts: SettingsContext<any>[]; | ||
readonly tabControl: TabControl; | ||
|
||
constructor( | ||
public _injector: Injector, | ||
@Optional() @Inject(DIALOG_DATA) public data: SettingsDialogData, | ||
private registry: SettingsRegistry, | ||
private dialogRef: DialogRef<SettingsDialogComponent, void>, | ||
) { | ||
this.settingContexts = this.registry.getSettings(); | ||
this.tabControl = new TabControl(this.settingContexts.map(context => ({ | ||
id: context.id, | ||
name: context.tabName, | ||
value: context.id, | ||
}))); | ||
} | ||
|
||
ngOnInit(): void { | ||
if (this.data && this.data.initialSettingId) { | ||
this.tabControl.selectTabByValue(this.data.initialSettingId); | ||
} else { | ||
this.tabControl.selectFirstTab(); | ||
} | ||
} | ||
|
||
closeThisDialog(): void { | ||
this.dialogRef.close(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { Injectable } from '@angular/core'; | ||
import { Dialog, DialogRef } from '../../ui/dialog'; | ||
import { SettingsDialogData } from './settings-dialog-data'; | ||
import { SettingsDialogComponent } from './settings-dialog.component'; | ||
|
||
|
||
@Injectable() | ||
export class SettingsDialog { | ||
constructor(private dialog: Dialog) { | ||
} | ||
|
||
open(data?: SettingsDialogData): DialogRef<SettingsDialogComponent, void> { | ||
return this.dialog.open<SettingsDialogComponent, | ||
SettingsDialogData, | ||
void>( | ||
SettingsDialogComponent, | ||
{ | ||
width: '500px', | ||
maxHeight: '75vh', | ||
disableBackdropClickClose: true, | ||
data, | ||
}, | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { NgModule } from '@angular/core'; | ||
import { UiModule } from '../ui/ui.module'; | ||
import { SettingsDialog } from './settings-dialog/settings-dialog'; | ||
import { SettingsDialogComponent } from './settings-dialog/settings-dialog.component'; | ||
import { SettingsRegistry } from './settings-registry'; | ||
|
||
|
||
@NgModule({ | ||
imports: [ | ||
UiModule, | ||
], | ||
declarations: [SettingsDialogComponent], | ||
entryComponents: [ | ||
SettingsDialogComponent, | ||
], | ||
providers: [ | ||
SettingsDialog, | ||
SettingsRegistry, | ||
], | ||
exports: [SettingsDialogComponent], | ||
}) | ||
export class SettingsModule { | ||
} |