[ci skip] Apply suggestions from code review

Co-Authored-By: Enrico Seiler <eseiler@users.noreply.github.com>

include/seqan3/argument_parser/argument_parser.hpp

@@ -230,8 +230,8 @@ class argument_parser
      */
     template <typename option_type, validator validator_type = detail::default_validator<option_type>>
     //!\cond
-        requires  (argument_parser_compatible_option<option_type> ||
-                   argument_parser_compatible_option<typename option_type::value_type>) &&
+        requires (argument_parser_compatible_option<option_type> ||
+                  argument_parser_compatible_option<typename option_type::value_type>) &&
                   std::invocable<validator_type, option_type>
     //!\endcond
     void add_option(option_type & value,
@@ -292,9 +292,9 @@ class argument_parser
      */
     template <typename option_type, validator validator_type = detail::default_validator<option_type>>
     //!\cond
-        requires  (argument_parser_compatible_option<option_type> ||
-                   argument_parser_compatible_option<typename option_type::value_type>) &&
-                   std::invocable<validator_type, option_type>
+        requires (argument_parser_compatible_option<option_type> ||
+                  argument_parser_compatible_option<typename option_type::value_type>) &&
+                  std::invocable<validator_type, option_type>
     //!\endcond
     void add_positional_option(option_type & value,
                                std::string const & desc,

include/seqan3/argument_parser/auxiliary.hpp

@@ -38,7 +38,7 @@ namespace seqan3::custom
  * Please note that by default the `t const`, `t &` and `t const &` specialisations of this class inherit the
  * specialisation for `t` so you usually only need to provide a specialisation for `t`.
  *
- * \note Only use this, if you cannot provide respective functions in your namespace.
+ * \note Only use this if you cannot provide respective functions in your namespace.
  */
 template <typename t>
 struct string_convertiblity
@@ -100,7 +100,7 @@ namespace seqan3
 
 /*!\brief Return the rank representation of a (semi-)alphabet object.
  * \tparam your_type Type of the argument.
- * \param  alph      The (semi-)alphabet object.
+ * \param alph The (semi-)alphabet object.
  * \returns The rank representation; an integral type.
  * \ingroup alphabet
  * \details

include/seqan3/argument_parser/detail/format_parse.hpp

@@ -322,7 +322,7 @@ class format_parse : public format_base
         auto it = seqan3::string_conversion_map(value).find(tmp);
 
         if (it == seqan3::string_conversion_map(value).end())
-            throw type_conversion_failed("Argument " + in + " could not be casted to enum type " +
+            throw type_conversion_failed("Argument " + in + " could not be cast to enum type " +
                                          get_display_name_v<option_t>.str() + ".");
         else
             value = it->second;

test/snippet/argument_parser/string_conversion_map.cpp

@@ -27,7 +27,7 @@ int main(int argc, char const * argv[])
 
     // Because of the string_conversion_map function
     // you can now add an option that takes a value of type Foo:
-    parser.add_option(value, 'f', "foo", "Give me a value foo value.");
+    parser.add_option(value, 'f', "foo", "Give me a foo value.");
 
     try
     {

test/snippet/argument_parser/string_convertible.cpp

@@ -3,11 +3,11 @@
 
 namespace seqan3::custom
 {
-// specialise the seqan3::custom::string_convertiblity data structure to enable parsing of std::errc.
+// Specialise the seqan3::custom::string_convertiblity data structure to enable parsing of std::errc.
 template <>
 struct string_convertiblity<std::errc>
 {
-    // specialise a mapping from your values of type Foo to the respective string
+    // Specialise a mapping from your values of type Foo to the respective string.
     static auto string_conversion_map(std::errc)
     {
         return std::unordered_map<std::string, std::errc>
@@ -29,8 +29,8 @@ int main(int argc, char const * argv[])
 
     // Because of the string_convertiblity struct and
     // the static member function string_conversion_map
-    // you can now add an option that takes a value of type Foo:
-    parser.add_option(value, 'e', "errc", "Give me a value std::errc value.");
+    // you can now add an option that takes a value of type std::errc:
+    parser.add_option(value, 'e', "errc", "Give me a std::errc value.");
 
     try
     {

test/unit/argument_parser/format_parse_test.cpp

@@ -594,7 +594,7 @@ auto string_conversion_map(Foo)
 {
     return std::unordered_map<std::string, Foo>{{{"one", Foo::one}, {"two", Foo::two}, {"three", Foo::three}}};
 }
-} // namespace bar
+} // namespace Bar
 
 namespace Other
 {

test/unit/core/debug_stream_test.cpp

@@ -238,7 +238,7 @@ TEST(debug_stream_test, string_convertible)
     o.flush();
     EXPECT_EQ(o.str(), "one");
 
-    fo = Foo::three; // unknown to the converion map
+    fo = Foo::three; // unknown to the conversion map
 
     my_stream << fo;
     o.flush();