-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add alignment cache #1243
Conversation
4a50eab
to
5913290
Compare
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 221 221
Lines 8912 8912
=======================================
Hits 8677 8677
Misses 235 235 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expressive names could be used in the unit test here: https://github.com/seqan/seqan3/blob/5913290cf1b38e9e488a42a571d5a6c48873641b/test/unit/alignment/pairwise/policy/affine_gap_banded_init_policy_test.cpp#L98-99.
Where/How is make_cache() defined?
5913290
to
9b2c798
Compare
9b2c798
to
a913963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is weird to merge something without a use case but I guess you will refactor this later on.
Well, no one want's to review a >2k LOC change either so at some level I have to make a compromise 🤷♂ |
A lot of these parts will be removed when I am done with the whole refactoring. |
Adds little helper class for the alignment cache instead of using a tuple which is hard to read since we can't use expressive namings for the variables.
NOTE: Only the last commit is relevant.