Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Io bam performance #3106

Merged
merged 7 commits into from
Jan 6, 2023
Merged

Io bam performance #3106

merged 7 commits into from
Jan 6, 2023

Conversation

smehringer
Copy link
Member

@smehringer smehringer commented Nov 28, 2022

🤞

SAM

Benchmark a small SAM file (/group/ag_abi/gene/benchmark-files/io-test.bam as SAM):
Before: Elapsed (wall clock) time (h:mm:ss or m:ss): 0:10.33
After: Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.60
Seqan2: Elapsed (wall clock) time (h:mm:ss or m:ss): 0:06.19

BAM

Benchmark a small BAM file (/group/ag_abi/gene/benchmark-files/io-test.bam):
Before: Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.42
After: Elapsed (wall clock) time (h:mm:ss or m:ss): 0:02.66
Seqan2: Elapsed (wall clock) time (h:mm:ss or m:ss): 0:01.47

Looks like I need to make this pretty s.t. it can be merged.

@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 10:29AM (UTC)

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 28, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 29, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 98.22% // Head: 98.18% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (7b762b8) compared to base (4a586be).
Patch coverage: 96.99% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   98.22%   98.18%   -0.04%     
==========================================
  Files         275      276       +1     
  Lines       12192    12277      +85     
==========================================
+ Hits        11975    12054      +79     
- Misses        217      223       +6     
Impacted Files Coverage Δ
include/seqan3/io/sam_file/format_sam.hpp 93.68% <94.80%> (-1.42%) ⬇️
include/seqan3/io/sam_file/format_bam.hpp 94.51% <96.05%> (-0.42%) ⬇️
include/seqan3/io/detail/misc_input.hpp 96.36% <100.00%> (+0.06%) ⬆️
include/seqan3/io/sam_file/detail/cigar.hpp 95.00% <100.00%> (-5.00%) ⬇️
...lude/seqan3/io/sam_file/detail/format_sam_base.hpp 98.88% <100.00%> (+1.06%) ⬆️
...qan3/io/stream/detail/fast_istreambuf_iterator.hpp 100.00% <100.00%> (ø)
test/include/seqan3/test/literal/cigar_literal.hpp 100.00% <100.00%> (ø)
test/include/seqan3/test/streambuf.hpp 100.00% <100.00%> (ø)
include/seqan3/io/structure_file/format_vienna.hpp 96.10% <0.00%> (-1.46%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 30, 2022
@eseiler eseiler self-requested a review December 5, 2022 12:33
@eseiler eseiler marked this pull request as ready for review December 5, 2022 12:57
include/seqan3/io/sam_file/detail/cigar.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/detail/format_sam_base.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/detail/format_sam_base.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/detail/format_sam_base.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/detail/cigar.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/format_bam.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/format_bam.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/format_bam.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/format_bam.hpp Outdated Show resolved Hide resolved
include/seqan3/io/sam_file/format_bam.hpp Outdated Show resolved Hide resolved
@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Jan 3, 2023
@seqan-actions seqan-actions removed the lint [INTERNAL] signal for linting label Jan 3, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 3, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 3, 2023
@eseiler eseiler mentioned this pull request Jan 4, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 5, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 5, 2023
Co-authored-by: Enrico Seiler <enrico.seiler@hotmail.de>
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 5, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 6, 2023
eseiler and others added 6 commits January 6, 2023 11:24
Co-authored-by: Svenja Mehringer <svenja.mehringer@fu-berlin.de>
Co-authored-by: Svenja Mehringer <svenja.mehringer@fu-berlin.de>
Co-authored-by: Svenja Mehringer <svenja.mehringer@fu-berlin.de>
Co-authored-by: Svenja Mehringer <svenja.mehringer@fu-berlin.de>
Co-authored-by: Svenja Mehringer <svenja.mehringer@fu-berlin.de>
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 6, 2023
@eseiler eseiler enabled auto-merge January 6, 2023 10:28
@eseiler eseiler merged commit 98f9ee8 into seqan:master Jan 6, 2023
@smehringer smehringer deleted the io_BAM_performance branch November 27, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants