Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix response status check #56

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Fix response status check #56

merged 2 commits into from
Jan 28, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Jan 27, 2020

No description provided.

@at-wat at-wat self-assigned this Jan 27, 2020
@sqbot
Copy link
Member

sqbot commented Jan 27, 2020 •
edited
Loading

[#127] PASSED on ROS kinetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 2 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 23 tests, 0 errors, 0 failures, 0 skipped

[#127] PASSED on ROS melodic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 2 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 23 tests, 0 errors, 0 failures, 0 skipped

@sqbot
Copy link
Member

sqbot commented Jan 27, 2020 •
edited
Loading

[#128] PASSED on ROS kinetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 2 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 23 tests, 0 errors, 0 failures, 0 skipped

[#128] PASSED on ROS melodic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 2 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 23 tests, 0 errors, 0 failures, 0 skipped

ykoga-kyutech
ykoga-kyutech approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@ykoga-kyutech ykoga-kyutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit d11c343 into master Jan 28, 2020
@at-wat at-wat deleted the fix-response-error-check branch January 28, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykoga-kyutech ykoga-kyutech ykoga-kyutech approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@at-wat @sqbot @ykoga-kyutech