Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unuse downloaded scripts #128

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Unuse downloaded scripts #128

merged 2 commits into from
Dec 20, 2022

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Dec 20, 2022

Unuse deprecated codecov bash uploader and gh-pr-comment installer

@at-wat at-wat self-assigned this Dec 20, 2022
@sqbot
Copy link
Member

sqbot commented Dec 20, 2022

[114] PASSED on noetic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 43 tests, 0 errors, 0 failures, 0 skipped

[114] PASSED on melodic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 43 tests, 0 errors, 0 failures, 0 skipped

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 90.39% // Head: 90.39% // No change to project coverage 👍

Coverage data is based on head (420e0c3) compared to base (35852ec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          15       15           
  Lines         281      281           
=======================================
  Hits          254      254           
  Misses         27       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@at-wat at-wat requested a review from f-fl0 December 20, 2022 03:08
Copy link
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a question.

tester \
/catkin_ws/src/self/.github/test.sh
- uses: codecov/codecov-action@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this downloads the required codecov files in GITHUB_WORKSPACE. Is that correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action uploads coverage reports under GITHUB_WORKSPACE to codecov.
I think it doesn't download anything under GITHUB_WORKSPACE.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, the .gcov files are generated inside the docker container and copied into the mounted volume GITHUB_WORKSPACE.

@at-wat at-wat merged commit f1cf08d into master Dec 20, 2022
@at-wat at-wat deleted the unuse-downloaded-script branch December 20, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants