-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unuse downloaded scripts #128
Conversation
[114] PASSED on noeticAll tests passed
[114] PASSED on melodicAll tests passed
|
Codecov ReportBase: 90.39% // Head: 90.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 15 15
Lines 281 281
=======================================
Hits 254 254
Misses 27 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a question.
tester \ | ||
/catkin_ws/src/self/.github/test.sh | ||
- uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this downloads the required codecov files in GITHUB_WORKSPACE
. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action uploads coverage reports under GITHUB_WORKSPACE
to codecov.
I think it doesn't download anything under GITHUB_WORKSPACE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, the .gcov
files are generated inside the docker container and copied into the mounted volume GITHUB_WORKSPACE
.
Unuse deprecated codecov bash uploader and gh-pr-comment installer