fix(pattern-validation-error): Throw error when a file is not matching the pattern #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the pattern rather than silently ignoring it
…g the pattern rather than silently ignoring it
…nvr/umzug into fix/pattern-validation-error
jukkah
reviewed
Apr 22, 2017
| @@ -416,6 +416,9 @@ var Umzug = module.exports = redefine.Class(/** @lends Umzug.prototype */ { | |||
| .promisify(fs.readdir)(this.options.migrations.path) | |||
| .bind(this) | |||
| .filter(function (file) { | |||
| if(!this.options.migrations.pattern.test(file)) { | |||
| throw new Error('File: ' + file + ' does not match pattern: ' + this.options.migrations.pattern); | |||
There was a problem hiding this comment.
Throw doesn't work as it breaks this down if there is at least one file that doesn't match to the pattern. It should be some kind of console.warn() instead.
|
I've made much refactoring in the code base or at least git thinks so. To help you, I rewrite this in 890e5e1 so that you don't need to update your code. |
jukkah
added a commit
to jukkah/umzug
that referenced
this pull request
Apr 24, 2017
jukkah
added a commit
that referenced
this pull request
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a trivial logging addition to disclose when a migration task file pattern is not matching the default one. It seems to be a common gotcha that would save a lot of time to Umzug adopters because invalid file patterns are silently ignored.