Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove uniqueness from sequelize storage #602

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Conversation

mau31415
Copy link
Contributor

…tries in case of rerun

Copy link

@danAlmogSB danAlmogSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful change

@mmkal
Copy link
Contributor

mmkal commented Apr 17, 2023

Thanks. Could you add a test that fails without this change so the reason is clear?

@mau31415
Copy link
Contributor Author

added a test and updated relevant changes to existing tests

@mau31415 mau31415 closed this Apr 18, 2023
@mau31415 mau31415 reopened this Apr 18, 2023
@WikiRik WikiRik requested review from mmkal and removed request for danAlmogSB June 28, 2023 08:43
@mmkal mmkal enabled auto-merge (squash) July 6, 2023 03:09
@mmkal mmkal disabled auto-merge July 6, 2023 03:09
@mmkal mmkal changed the title remove uniqueness from the sequelize storage as it can be multiple en… feat: remove uniqueness from sequelize storage Jul 6, 2023
@mmkal mmkal merged commit 15fc2fe into sequelize:main Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Released in v3.3.0.

mmkal added a commit that referenced this pull request Aug 3, 2023
@jbalatero
Copy link

Since this was reverted, how do we work around --rerun ALLOW now?

@mau31415
Copy link
Contributor Author

mau31415 commented Aug 4, 2024

I solved it on my end, I didn't have time to create a better fix. Sorry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants