Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to dtolnay/toolchain #211

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Move to dtolnay/toolchain #211

merged 3 commits into from
Jan 9, 2023

Conversation

kayabaNerve
Copy link
Member

actions-rs/toolchain is unmaintained (actions-rs/toolchain#216).

actions-rs will stop working in a few months thanks to the deprecation of set-output and NodeJS 12 (actions-rs/toolchain#219 and actions-rs/toolchain#221, respectively).

This moves to https://github.com/dtolnay/rust-toolchain, which is maintained, and deletes cached-rust per commentary in dtolnay/rust-toolchain#26. We may later want to add https://github.com/Swatinem/rust-cache/ in.

@kayabaNerve kayabaNerve added improvement This could be better CI/CD Continuous integration workflows labels Jan 9, 2023
Introduces malleability by referring to HEAD of dtolnay, yet GHA errored on the
prior syntax.
@kayabaNerve
Copy link
Member Author

Tests take notably longer. Will merge this and create issue for cache.

@kayabaNerve kayabaNerve merged commit ea7c281 into develop Jan 9, 2023
@kayabaNerve kayabaNerve deleted the dtolnay-toolchain branch January 9, 2023 22:21
@pinkforest
Copy link

pstt fyi I forked https://github.com/rustsec/audit-check - PR's welcome

There was a discussion that we might host some simple version that doesn't require NodeJS

@kayabaNerve
Copy link
Member Author

Sorry, yet I'm not entirely sure where/what you forked.

As for a version which doesn't require NodeJS, that sounds great just as we're discussing minimizing bloat. I don't think it's worthwhile enough for us to move though. If it also handled toolchain caching intelligently, that'd be pleasant though (since we use stable, nightly, additional targets, various components, update nightly monthly...). Would love to not hammer Rust's servers while also only downloading relevant pieces from the cache (while simultaneously not getting stuck on an old version of nightly from the cache).

Feel free to clarify, as I wouldn't necessarily mind poking around :) I'd also love if an org handled it, not an individual...

@pinkforest
Copy link

We forked https://github.com/actions-rs/audit-check/ into https://github.com/rustsec/audit-check

I guess we need to address this/these deprecation/s there now too in our fork

@kayabaNerve
Copy link
Member Author

Ah, got it, thanks. We actually don't currently use audit-check. We use deny, which also handles advisories, yet also yankings/licenses, so that wasn't relevant to us.

Forking the existing action, and merging the open PRs on it, would be seamless to everyone else. RustSec also should be a trusted organization. I'd love to see y'all step up to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration workflows improvement This could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants