Fix mingo version so that yarn doesn't upgrade it #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingo introduced a breaking change in v1.3.0 (removing the Mingo.setup method). This causes failures when installing save via mongo when no yarn.lock is present. This project uses the new npm 5 package-lock.json, this is not supported by yarn and so mingo gets silently upgraded from 1.1.2 to 1.3.0. It is likely that this project will need to upgrade to the mingo 1.3.0 API, but in the meantime this commit will ensure that 1.1.2 gets installed when using yarn. yarnpkg/yarn#3614
|
I've tried to refactor to use the newest. I'm not sure |
|
thanks for opening that issue on mingo, I've re-installed save and the mingo upgrade has sorted the problem, so I'm closing this PR> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mingo introduced a breaking change in v1.3.0 (removing the Mingo.setup
method). This causes failures when installing save via mongo when no
yarn.lock is present.
This project uses the new npm 5 package-lock.json, this is not supported
by yarn and so mingo gets silently upgraded from 1.1.2 to 1.3.0. It is
likely that this project will need to upgrade to the mingo 1.3.0 API,
but in the meantime this commit will ensure that 1.1.2 gets installed
when using yarn.
yarnpkg/yarn#3614