test_runner: expose spec reporter as newable function

Fixes: nodejs/node#48112 Ref: nodejs/node#48208 PR-URL: nodejs/node#49184 Refs: nodejs/node#48208 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher · Apr 25, 2024 · 6d13858 · 6d13858
1 parent 7b5134a
commit 6d13858
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 12 deletions.
diff --git a/graal-nodejs/lib/test/reporters.js b/graal-nodejs/lib/test/reporters.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const { ObjectDefineProperties } = primordials;
+const { ObjectDefineProperties, ReflectConstruct } = primordials;
 
 let dot;
 let spec;
@@ -21,9 +21,9 @@ ObjectDefineProperties(module.exports, {
     __proto__: null,
     configurable: true,
     enumerable: true,
-    get() {
+    value: function value() {
       spec ??= require('internal/test_runner/reporter/spec');
-      return spec;
+      return ReflectConstruct(spec, arguments);
     },
   },
   tap: {

diff --git a/graal-nodejs/test/parallel/test-runner-run.mjs b/graal-nodejs/test/parallel/test-runner-run.mjs
@@ -82,15 +82,28 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
     ]);
   });
 
-  it('should be piped with spec', async () => {
-    const specReporter = new spec();
-    const result = await run({
-      files: [join(testFixtures, 'default-behavior/test/random.cjs')]
-    }).compose(specReporter).toArray();
-    const stringResults = result.map((bfr) => bfr.toString());
-    assert.match(stringResults[0], /this should pass/);
-    assert.match(stringResults[1], /tests 1/);
-    assert.match(stringResults[1], /pass 1/);
+  describe('should be piped with spec reporter', () => {
+    it('new spec', async () => {
+      const specReporter = new spec();
+      const result = await run({
+        files: [join(testFixtures, 'default-behavior/test/random.cjs')]
+      }).compose(specReporter).toArray();
+      const stringResults = result.map((bfr) => bfr.toString());
+      assert.match(stringResults[0], /this should pass/);
+      assert.match(stringResults[1], /tests 1/);
+      assert.match(stringResults[1], /pass 1/);
+    });
+
+    it('spec()', async () => {
+      const specReporter = spec();
+      const result = await run({
+        files: [join(testFixtures, 'default-behavior/test/random.cjs')]
+      }).compose(specReporter).toArray();
+      const stringResults = result.map((bfr) => bfr.toString());
+      assert.match(stringResults[0], /this should pass/);
+      assert.match(stringResults[1], /tests 1/);
+      assert.match(stringResults[1], /pass 1/);
+    });
   });
 
   it('should be piped with tap', async () => {