This repository has been archived by the owner on May 6, 2020. It is now read-only.
Repetition for unquotation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczarn
force-pushed
the
sequence-repetition
branch
3 times, most recently
from
ed06b85 to
8920300
Compare
pczarn
force-pushed
the
sequence-repetition
branch
from
8920300 to
761674e
Compare
| ); | ||
|
|
||
| assert_eq!(pprust::expr_to_string(&expr), "(1 + 2, 2 * 3)"); | ||
| } |
|
For now, I'd like to add repetition to quasi, not to rustc's libsyntax, because prototyping is easier with aster and in a small repository. |
|
@erickt could you review and merge? |
|
/cc rust-lang/rust#24224 "syntax: Repeating fragments in quasiquotation" |
|
|
||
| let unit = (); | ||
|
|
||
| quote_expr!(&cx, |
There was a problem hiding this comment.
Could you test the value here? I'm guessing it's assert_eq!(pprust::expr_to_string(&expr), "()"); but it'd be nice to be sure.
edit: oops, I didn't see it was a #[should_panic], nevermind.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.